chia7712 commented on code in PR #21607:
URL: https://github.com/apache/kafka/pull/21607#discussion_r2869681508
##########
metadata/src/main/java/org/apache/kafka/metadata/ListenerInfo.java:
##########
@@ -134,7 +134,7 @@ public static ListenerInfo fromControllerRegistrationRecord(
* @return The ListenerInfo object.
*/
public static ListenerInfo fromBrokerRegistrationRequest(
- BrokerRegistrationRequestData.ListenerCollection collection
+ List<BrokerRegistrationRequestData.Listener> collection
) {
LinkedHashMap<String, Endpoint> listeners = new LinkedHashMap<>();
Review Comment:
It seems I overlooked the usage before. It requires unique names, so
`mapKey` actually protects us at the RPC layer. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
