iit2009060 commented on code in PR #21117:
URL: https://github.com/apache/kafka/pull/21117#discussion_r2881819225
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -956,7 +955,10 @@ private void handleTimeoutFailure(long now, Throwable
cause) {
log.debug("{} timed out at {} after {} attempt(s)", this, now,
tries,
new Exception(prettyPrintException(cause)));
}
- if (cause instanceof TimeoutException) {
+ // Don't mask OutOfMemoryError as TimeoutException - propagate it
directly
+ if (cause instanceof OutOfMemoryError) {
Review Comment:
Yes that should also not be treated a timedout error , we can open a
separate JIRA to handle this specific errors to move out of timedout
exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
