chia7712 commented on code in PR #21575:
URL: https://github.com/apache/kafka/pull/21575#discussion_r2882942413
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/LogCleanerLagIntegrationTest.java:
##########
@@ -345,6 +598,13 @@ private void closeLog(UnifiedLog log) throws IOException {
logs.remove(log);
}
+ @AfterEach
+ public void cleanup() {
+ for (MetricName metricName :
KafkaYammerMetrics.defaultRegistry().allMetrics().keySet()) {
Review Comment:
> create JIRA to migrate this into TestUtils (i.e., test-common-runtime)?
And then just replace all these kafka.utils.TestUtils.clearYammerMetrics() with
Java implementation WDYT? That would avoid a lot of un-necessary changes ...
and we can split the work.
sound good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
