squah-confluent commented on code in PR #21627:
URL: https://github.com/apache/kafka/pull/21627#discussion_r2883611043


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -93,6 +113,10 @@ public final class GroupConfig extends AbstractConfig {
 
     public final String shareAutoOffsetReset;
 
+    public final int shareAssignmentIntervalMs;
+
+    public final Optional<Boolean> shareAssignorOffloadEnable;

Review Comment:
   These group-level configs were tricky. We need a special value to denote 
"use the group coordinator config". For ints, that is -1. For booleans, we have 
to use `null` or make the configs strings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to