mjsax commented on code in PR #21580:
URL: https://github.com/apache/kafka/pull/21580#discussion_r2887463579
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueChangeBuffer.java:
##########
@@ -447,7 +447,7 @@ public Maybe<ValueAndTimestamp<V>>
priorValueForBuffered(final K key) {
// it's unfortunately not possible to know this, unless we
materialize the suppressed result, since our only
// knowledge of the prior value is what the upstream processor
sends us as the "old value" when we first
// buffer something.
- return Maybe.defined(ValueAndTimestamp.make(deserializedValue,
RecordQueue.UNKNOWN));
+ return Maybe.defined(ValueTimestampHeaders.make(deserializedValue,
RecordQueue.UNKNOWN, new RecordHeaders()));
Review Comment:
In other places we pass `null` as header as default (what is fine, because
it's getting replace with `new RecordHeaders()` inside `ValueTimestampHeaders`
constructor). But I think we should be consistent, so maybe pass in `null` here
too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
