mjsax commented on code in PR #21599:
URL: https://github.com/apache/kafka/pull/21599#discussion_r2887528547
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/WindowStoreMaterializer.java:
##########
@@ -56,6 +56,7 @@ public WindowStoreMaterializer(
@Override
public StoreBuilder<?> builder() {
+ final DslStoreFormat storeFormat = dslStoreFormat() == null ?
DslStoreFormat.TIMESTAMPED : DslStoreFormat.HEADERS;
Review Comment:
That we are doing this translation inside the "materializer" code is still
bugging me... It works, but it just doesn't feels right... I left a similar
comment on Alieh's first PR which introduced this for kv-store case.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
