mjsax commented on code in PR #21600: URL: https://github.com/apache/kafka/pull/21600#discussion_r2887588449
########## streams/src/main/java/org/apache/kafka/streams/state/internals/SessionStoreIteratorFacade.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.state.internals; + +import org.apache.kafka.streams.KeyValue; +import org.apache.kafka.streams.state.AggregationWithHeaders; +import org.apache.kafka.streams.state.KeyValueIterator; + +/** + * Wraps a {@code KeyValueIterator<K, AggregationWithHeaders<V>>} to present a + * {@code KeyValueIterator<K, V>} by stripping the {@link AggregationWithHeaders} wrapper. + * <p> + * This is analogous to {@link KeyValueIteratorFacade} which strips {@code ValueAndTimestamp}. + * + * @param <K> the key type + * @param <V> the aggregated value type + */ +public class SessionStoreIteratorFacade<K, V> implements KeyValueIterator<K, V> { + private final KeyValueIterator<K, AggregationWithHeaders<V>> innerIterator; + + public SessionStoreIteratorFacade(final KeyValueIterator<K, AggregationWithHeaders<V>> iterator) { + innerIterator = iterator; + } + + @Override + public boolean hasNext() { + return innerIterator.hasNext(); + } + + @Override + public K peekNextKey() { + return innerIterator.peekNextKey(); + } + + @Override + public KeyValue<K, V> next() { + final KeyValue<K, AggregationWithHeaders<V>> innerKeyValue = innerIterator.next(); + return KeyValue.pair(innerKeyValue.key, AggregationWithHeaders.getAggregationOrNull(innerKeyValue.value)); Review Comment: I think we need a guard for `innerKeyValue == null` and return `null` for this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
