mimaison commented on code in PR #21330:
URL: https://github.com/apache/kafka/pull/21330#discussion_r2895796231
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginsTest.java:
##########
@@ -717,15 +717,15 @@ public byte[] fromConnectData(String topic, Schema
schema, Object value) {
public SchemaAndValue toConnectData(String topic, byte[] value) {
return null;
}
+ }
Review Comment:
`TestConverter` still implements `Versioned`
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginsTest.java:
##########
@@ -727,6 +727,11 @@ public String version() {
public static class TestHeaderConverter implements HeaderConverter {
public Map<String, ?> configs;
+ @Override
+ public String version() {
+ return "test";
+ }
+
Review Comment:
My comment still stands, do we need this `version()` method in
`TestHeaderConverter`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
