squah-confluent commented on code in PR #21652:
URL: https://github.com/apache/kafka/pull/21652#discussion_r2898823659
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/ModernGroup.java:
##########
@@ -45,6 +45,18 @@
*/
public abstract class ModernGroup<T extends ModernGroupMember> implements
Group {
+ /**
+ * The target assignment metadata.
+ *
+ * @param assignmentEpoch The target assignment epoch. An assignment
epoch smaller than the
+ * group epoch means that a new assignment is
required. The
+ * assignment epoch is updated when a new
assignment is installed.
+ * @param assignmentTimestamp The time at which the target assignment
calculation finished.
+ */
+ protected static record TargetAssignmentMetadata(int assignmentEpoch, long
assignmentTimestamp) {
+ private static final TargetAssignmentMetadata NONE = new
TargetAssignmentMetadata(0, 0L);
Review Comment:
Actually, I realize that we set the assignment epoch to -1 when replaying a
tombstone. I think both initial and tombstoned values ought to be the same.
However changing the initial epoch to -1 causes a handful of tests to fail
(DescribeGroup in a bunch of tests returns a negative epoch and consumer groups
entering the ASSIGNING state because assignment epoch -1 lags behind group
epoch 0). I'd rather not untangle this right now and the PR is large enough.
https://issues.apache.org/jira/browse/KAFKA-20271
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TargetAssignmentBuilder.java:
##########
@@ -304,6 +320,17 @@ public TargetAssignmentBuilder(
this.assignor = Objects.requireNonNull(assignor);
}
+ /**
+ * Sets the time.
+ *
+ * @param time The time.
+ * @return This object.
+ */
+ public U withTime(Time time) {
+ this.time = time;
Review Comment:
Thanks for the review. I think it's a good idea. But we don't currently
requireNotNull for any of the other fields in this builder and I would like to
keep the style consistent.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/TargetAssignmentMetadata.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.coordinator.group;
+
+/**
+ * The target assignment metadata.
+ *
+ * @param assignmentEpoch The target assignment epoch. An assignment epoch
smaller than the
+ * group epoch means that a new assignment is
required. The
+ * assignment epoch is updated when a new
assignment is installed.
+ * @param assignmentTimestamp The time at which the target assignment
calculation finished.
+ */
+public record TargetAssignmentMetadata(int assignmentEpoch, long
assignmentTimestamp) {
+ public static final TargetAssignmentMetadata NONE = new
TargetAssignmentMetadata(0, 0L);
+}
Review Comment:
Good idea, thanks.
We set the assignment epoch to -1 when replaying an assignment tombstone, so
we have to allow that value too.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TargetAssignmentBuilder.java:
##########
@@ -506,7 +533,8 @@ protected abstract CoordinatorRecord
newTargetAssignmentRecord(
protected abstract CoordinatorRecord newTargetAssignmentEpochRecord(
Review Comment:
Good catch, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
