mjsax commented on code in PR #21684:
URL: https://github.com/apache/kafka/pull/21684#discussion_r2907053329
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreWithHeaders.java:
##########
@@ -102,12 +102,12 @@ public ValueTimestampHeaders<V> putIfAbsent(final K key,
public <R> QueryResult<R> query(final Query<R> query,
final PositionBound positionBound,
final QueryConfig config) {
- throw new UnsupportedOperationException("Queries (IQv2) are not
supported for timestamped key-value stores with headers yet.");
+ throw new UnsupportedOperationException("Querying is not supported for
" + getClass().getSimpleName());
}
@Override
public Position getPosition() {
- throw new UnsupportedOperationException("Position is not supported by
timestamped key-value stores with headers yet.");
+ throw new UnsupportedOperationException("Position is not supported for
" + getClass().getSimpleName());
}
protected Bytes keyBytes(final K key, final Headers headers) {
Review Comment:
I was focusing on `MeteredKeyValueStore` only, as the PR is already large
enough. -- Would need to revisit both `MeteredTimestampedKeyValueStore` and
`MeteredTimestampedKeyValueStoreWithHeaders` as follow up to further cleanup,
in a follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
