squah-confluent commented on code in PR #21696:
URL: https://github.com/apache/kafka/pull/21696#discussion_r2911829377
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -276,6 +275,32 @@ private static class UpdateSubscriptionMetadataResult {
}
}
+ private record UpdateTargetAssignmentResult<T>(
+ int targetAssignmentEpoch,
+ T targetAssignment
+ ) {
+ private static UpdateTargetAssignmentResult<TasksTuple>
fromLastTargetAssignment(
+ StreamsGroup group,
+ Optional<StreamsGroupMember> member
+ ) {
+ if (member.isPresent()) {
+ if (member.get().instanceId().isPresent()) {
+ throw new UnsupportedOperationException("Static members
are not supported yet.");
+ }
Review Comment:
I was concerned that we would forget to update this method since #21565 is
already in flight. But looking at that PR, we should have a merge conflict
which is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
