dajac commented on code in PR #21695:
URL: https://github.com/apache/kafka/pull/21695#discussion_r2912591518
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -289,6 +289,16 @@ private static UpdateTargetAssignmentResult<Assignment>
fromLastTargetAssignment
group.targetAssignment(member.memberId(), member.instanceId())
);
}
+
+ private static UpdateTargetAssignmentResult<Assignment>
fromLastTargetAssignment(
+ ShareGroup group,
+ ShareGroupMember member
Review Comment:
I wonder whether we could generalize the existing one and use `ModernGroup`
and `ModernGroupMember`. Have you tried it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
