dubeyKartikay commented on PR #21679:
URL: https://github.com/apache/kafka/pull/21679#issuecomment-4042453103

   Couple of things i want to point out.
   1. I had to make the server module test files visible to `clients` and 
`storage` module.
   2. Had to edit checkstyle xml to allow imports from org.kafka.server.utils 
in `purgatory` submodule in storage.
   
   Both these seem icky to me, but the alternative was to duplicate code. 
   What are your thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to