bbejeck commented on code in PR #21617:
URL: https://github.com/apache/kafka/pull/21617#discussion_r2921346463
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/InMemorySessionStoreTest.java:
##########
@@ -35,6 +36,29 @@ StoreType storeType() {
return StoreType.InMemoryStore;
}
+ @Test
+ public void shouldCountNumEntries() {
+ final InMemorySessionStore store = new InMemorySessionStore("test",
RETENTION_PERIOD, "scope");
+ store.init(context, store);
+
+ assertEquals(0L, store.numEntries());
+
+ store.put(new Windowed<>(Bytes.wrap("a".getBytes()), new
SessionWindow(0, 0)), "1".getBytes());
Review Comment:
for these `store.put` calls lets put the paremters on new lines like
[here](https://github.com/apache/kafka/pull/21617/changes#diff-78878bf112715fa1c9b1f2b3db14fc5b54de8ce3c6804b5e167af143c51dc193R310)
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##########
@@ -169,6 +169,12 @@ private void registerMetrics() {
return 0L;
}
});
+ // Only register this metric if it is an in-memory store
Review Comment:
I think we can remove this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
