mimaison commented on code in PR #21726:
URL: https://github.com/apache/kafka/pull/21726#discussion_r2924764883
##########
clients/src/test/java/org/apache/kafka/clients/consumer/RangeAssignorTest.java:
##########
@@ -601,4 +600,13 @@ void initializeRacks(RackConfig rackConfig, int
maxConsumers) {
// rack-aware logic using the same tests.
AbstractPartitionAssignorTest.preferRackAwareLogic(assignor, true);
}
+
+ @SafeVarargs
+ private static <K, V> Map<K, V> orderedMap(Map.Entry<K, V>... entries) {
Review Comment:
Same question, why are we creating copies of `Utils.mkMap()`?
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java:
##########
@@ -1562,4 +1559,13 @@ protected void initializeRacks(RackConfig rackConfig) {
this.hasConsumerRack = rackConfig != RackConfig.NO_CONSUMER_RACK;
AbstractPartitionAssignorTest.preferRackAwareLogic(assignor, true);
}
+
+ @SafeVarargs
+ private static <K, V> Map<K, V> orderedMap(Map.Entry<K, V>... entries) {
Review Comment:
Why are we creating a new method here while we have `Utils.mkMap()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
