chickenchickenlove commented on PR #21565: URL: https://github.com/apache/kafka/pull/21565#issuecomment-4047248247
@mjsax @lucasbru Thank you both for your comments! I think some of the points you mentioned are already addressed, while others are not yet covered. For example, cases where assignments need to be recalculated seem to be handled (topology, processId, clientTags, rackId). However, I haven’t verified yet whether changes to application.server in a static member are propagated to other members. I will validate this through test code. I have one question: in this PR, should we consider scenarios where static and dynamic members coexist? This may be related to online migration, but I’m not sure whether it should be handled within the scope of this PR or addressed as part of the online migration work separately. If there are any other aspects you think I should consider, please let me know. I’ll review my code and update both the implementation and the test cases accordingly 🙇♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
