muralibasani commented on code in PR #21751:
URL: https://github.com/apache/kafka/pull/21751#discussion_r2933378763
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -249,15 +249,23 @@ void openDB(final Map<String, Object> configs, final File
stateDir) {
// Setup statistics before the database is opened, otherwise the
statistics are not updated
// with the measurements from Rocks DB
setupStatistics(configs, dbOptions);
- openRocksDB(dbOptions, columnFamilyOptions);
- dbAccessor = new DirectDBAccessor(db, fOptions, wOptions);
+ boolean success = false;
try {
- cfAccessor.open(dbAccessor, !eosEnabled);
- } catch (final StreamsException fatal) {
- final String fatalMessage = "State store " + name + " didn't find
a valid state, since under EOS it has the risk of getting uncommitted data in
stores";
- throw new ProcessorStateException(fatalMessage, fatal);
- } catch (final RocksDBException e) {
- throw new ProcessorStateException("Error opening store " + name,
e);
+ openRocksDB(dbOptions, columnFamilyOptions);
Review Comment:
This method internally calls createColumnFamilies() or
mergeColumnFamilyHandleLists() which might fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
