[
https://issues.apache.org/jira/browse/KAFKA-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806240#comment-16806240
]
Dana Powers commented on KAFKA-4600:
------------------------------------
I don't think KAFKA-5154 is related to this issue. But maybe I'm reading this
ticket differently? I thought this ticket was literally about what happens when
the call to `listener.onPartitionsAssigned(assignedPartitions)` raises an
Exception. And because that call is currently wrapped in a bare `catch
(Exception e)`, and because the caught exception is logged but otherwise
ignored, it seems like this ticket should still be open or marked as wont fix.
I just don't see how KAFKA-5154 applies here – it was a fix for a NPE inside
KafkaStreams, but after onPartitionsAssigned() had already been called
successfully?
> Consumer proceeds on when ConsumerRebalanceListener fails
> ---------------------------------------------------------
>
> Key: KAFKA-4600
> URL: https://issues.apache.org/jira/browse/KAFKA-4600
> Project: Kafka
> Issue Type: Bug
> Components: consumer
> Affects Versions: 0.10.1.1
> Reporter: Braedon Vickers
> Priority: Major
> Fix For: 0.11.0.0
>
>
> One of the use cases for a ConsumerRebalanceListener is to load state
> necessary for processing a partition when it is assigned. However, when
> ConsumerRebalanceListener.onPartitionsAssigned() fails for some reason (i.e.
> the state isn't loaded), the error is logged and the consumer proceeds on as
> if nothing happened, happily consuming messages from the new partition. When
> the state is relied upon for correct processing, this can be very bad, e.g.
> data loss can occur.
> It would be better if the error was propagated up so it could be dealt with
> normally. At the very least the assignment should fail so the consumer
> doesn't see any messages from the new partitions, and the rebalance can be
> reattempted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
