squah-confluent commented on code in PR #21720:
URL: https://github.com/apache/kafka/pull/21720#discussion_r2939673341
##########
core/src/test/scala/unit/kafka/server/ConsumerProtocolMigrationTest.scala:
##########
@@ -277,18 +278,34 @@ class ConsumerProtocolMigrationTest(cluster:
ClusterInstance) extends GroupCoord
val groupId = "grp"
// Consumer member 1 joins the group.
- val (memberId1, _) = joinConsumerGroupWithNewProtocol(groupId,
Uuid.randomUuid.toString)
+ val (memberId1, memberEpoch1) = joinConsumerGroupWithNewProtocol(groupId,
Uuid.randomUuid.toString)
// Classic member 2 joins the group.
- val joinGroupResponseData = sendJoinRequest(
- groupId = groupId
- )
val memberId2 = sendJoinRequest(
- groupId = groupId,
- memberId = joinGroupResponseData.memberId,
- metadata = metadata(List.empty)
+ groupId = groupId
).memberId
+ // Wait until the group's target assignment is updated.
Review Comment:
Updated the PR to run the integration tests with and without assignment
batching.
Tests that aren't focused on assignments or upgrades all run without
assignment batching now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
