nicktelford commented on code in PR #21738:
URL: https://github.com/apache/kafka/pull/21738#discussion_r2940505819
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java:
##########
@@ -1040,36 +1032,6 @@ public void
shouldBeAbleToCloseWithoutRegisteringAnyStores() {
stateMgr.close();
}
- @Test
- public void shouldDeleteCheckPointFileIfEosEnabled() throws IOException {
Review Comment:
Deleting checkpoint files is now entirely handled by
`LegacyCheckpointingStateStore`, so I think this is covered by this test?
https://github.com/apache/kafka/blob/d7fed9d02354323fa031f99b758276cef2093afa/streams/src/test/java/org/apache/kafka/streams/state/internals/LegacyCheckpointingStateStoreTest.java#L330
The method this test calls, `stateMgr.deleteCheckPointFileIfEOSEnabled`, has
been completely removed, because (under EOS) we now delete the checkpoint file
in `init()` and only ever write it in `close()`. This ensures we don't
resurrect KAFKA-10362.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
