AndrewJSchofield commented on code in PR #21757:
URL: https://github.com/apache/kafka/pull/21757#discussion_r2940715946
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -228,12 +229,16 @@ public void process(ApplicationEvent event) {
}
private void process(final SharePollEvent event) {
-
requestManagers.shareMembershipManager.ifPresent(shareMembershipManager -> {
- shareMembershipManager.maybeReconcile(true);
- shareMembershipManager.onConsumerPoll();
+
requestManagers.shareMembershipManager.ifPresent(shareMembershipManager ->
+ shareMembershipManager.maybeReconcile(true));
+
+ requestManagers.shareHeartbeatRequestManager.ifPresent(hrm -> {
+ ShareMembershipManager membershipManager = hrm.membershipManager();
Review Comment:
I just followed the pattern with the other group types. I don't think there
was a reason this was different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
