chia7712 commented on code in PR #21709:
URL: https://github.com/apache/kafka/pull/21709#discussion_r2958529917
##########
docs/getting-started/quickstart.md:
##########
@@ -203,7 +203,7 @@ The [Kafka Streams demo](/documentation/streams/quickstart)
and the [app develop
## Step 8: Terminate the Kafka environment
-Now that you reached the end of the quickstart, feel free to tear down the
Kafka environment-or continue playing around.
+Now that you reached the end of the quickstart, feel free to tear down the
Kafka environment, or continue playing around.
Review Comment:
Could you remove the `,`?
##########
docs/kafka-connect/user-guide.md:
##########
@@ -63,7 +63,7 @@ Distributed mode handles automatic balancing of work, allows
you to scale up (or
$ bin/connect-distributed.sh config/connect-distributed.properties
-The difference is in the class which is started and the configuration
parameters which change how the Kafka Connect process decides where to store
configurations, how to assign work, and where to store offsets and task
statues. In the distributed mode, Kafka Connect stores the offsets, configs and
task statuses in Kafka topics. It is recommended to manually create the topics
for offset, configs and statuses in order to achieve the desired the number of
partitions and replication factors. If the topics are not yet created when
starting Kafka Connect, the topics will be auto created with default number of
partitions and replication factor, which may not be best suited for its usage.
+The difference is in the class which is started and the configuration
parameters which change how the Kafka Connect process decides where to store
configurations, how to assign work, and where to store offsets and task
statuses. In the distributed mode, Kafka Connect stores the offsets, configs
and task statuses in Kafka topics. It is recommended to manually create the
topics for offset, configs and statuses in order to achieve the desired the
number of partitions and replication factors. If the topics are not yet created
when starting Kafka Connect, the topics will be auto created with default
number of partitions and replication factor, which may not be best suited for
its usage.
Review Comment:
Would you mind revising one more for me?
`in order to achieve the desired the number` should be `to achieve the
desired number`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
