frankvicky commented on code in PR #21794:
URL: https://github.com/apache/kafka/pull/21794#discussion_r2960653043
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedSessionStore.java:
##########
@@ -31,12 +31,12 @@
import java.util.Objects;
public class RocksDBTimeOrderedSessionStore
- extends WrappedStateStore<RocksDBTimeOrderedSessionSegmentedBytesStore,
Object, Object>
+ extends WrappedStateStore<AbstractRocksDBTimeOrderedSegmentedBytesStore<?
extends Segment>, Object, Object>
implements SessionStore<Bytes, byte[]> {
private StateStoreContext stateStoreContext;
- RocksDBTimeOrderedSessionStore(final
RocksDBTimeOrderedSessionSegmentedBytesStore store) {
+ RocksDBTimeOrderedSessionStore(final
AbstractRocksDBTimeOrderedSegmentedBytesStore<? extends Segment> store) {
super(store);
Objects.requireNonNull(store, "store is null");
Review Comment:
Just a random things come to my mind:
There are are bunch of ternary operator for null check, do we consider to
replace it with `Objects.requireNonNullElse` to align the code style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
