kamalcph commented on code in PR #20913:
URL: https://github.com/apache/kafka/pull/20913#discussion_r3200774511
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -138,6 +144,10 @@ public Optional<String> serverConfigName(String
configName) {
public static final boolean DEFAULT_REMOTE_LOG_DELETE_ON_DISABLE_CONFIG =
false;
public static final long DEFAULT_LOCAL_RETENTION_BYTES = -2; // It
indicates the value to be derived from RetentionBytes
public static final long DEFAULT_LOCAL_RETENTION_MS = -2; // It indicates
the value to be derived from RetentionMs
+ public static final long DEFAULT_REMOTE_COPY_LAG_MS = -2; // It indicates
no delay check based on local retention ms
+ public static final long DEFAULT_REMOTE_COPY_LAG_BYTES = -2; // It
indicates no delay check based on local retention bytes
Review Comment:
> X: no check this one. but check another one.
This will break the deletion logic. Assume the topic-A have below configs:
```
retention.ms = 2 days
retention.bytes = 10 GB
local.retention.ms = 6 hour
remote.copy.lag.ms = 5.5 hour
remote.copy.lag.bytes = -2 (no check logic, default value)
```
Incoming traffic to fill the partition disk is 5 GB / hour. Will the
existing remote-copy lag logic allow the segment to upload for 5.5 hrs? At 5.5
hrs, the disk usage might be 27.5 GB exceeding the configured total retention
bytes of 10 GB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
