lucasbru commented on PR #22245: URL: https://github.com/apache/kafka/pull/22245#issuecomment-4553864396
Hey. Production code looks good to me. I think I like that we have the tests now in separate files, but I think I'd go back on some of the test helpers. The tests now look too inconsistent with all other tests. I left comments above - some of the helpers are better inlined, some make sense but we should probably apply them across all tests files at a later stage, and not have an island solution for this PR. Sorry, seems I led you in a wrong direction with one of my previous comments. Could you address my comments on the tests please? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
