[ 
https://issues.apache.org/jira/browse/KAFKA-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823230#comment-16823230
 ] 

ASF GitHub Bot commented on KAFKA-8275:
---------------------------------------

hachikuji commented on pull request #6619: KAFKA-8275; Take throttling into 
account when choosing least loaded node
URL: https://github.com/apache/kafka/pull/6619
 
 
   If a node is currently throttled, we should take it out of the running for 
`leastLoadedNode`. Additionally, current logic seems to favor connecting to new 
nodes rather than using existing connections which have one or more in flight 
requests. The javadoc is slightly vague about whether this is expected, but it 
seems not.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> NetworkClient leastLoadedNode selection should consider throttled nodes
> -----------------------------------------------------------------------
>
>                 Key: KAFKA-8275
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8275
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>            Priority: Major
>
> The leastLoadedNode() function is intended to find any available node. It is 
> smart in the sense that it considers the number of inflight requests and 
> reconnect backoff, but it has not been updated to take into account client 
> throttling. If we have an available node which is not throttled, we should 
> use it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to