chickenchickenlove commented on code in PR #22138:
URL: https://github.com/apache/kafka/pull/22138#discussion_r3421488027
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##########
@@ -1642,7 +1638,7 @@ public void
testAsyncConsumerCloseLeavesGroupOnInterrupt() throws Exception {
));
}
- private void testCloseLeavesGroupOnInterrupt(Map<String, Object>
consumerConfig) throws Exception {
+ private void testCloseRunsRevocationCallbackOnInterrupt(Map<String,
Object> consumerConfig) throws Exception {
Review Comment:
Good point!
I will replace them with unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]