mjsax commented on code in PR #22595:
URL: https://github.com/apache/kafka/pull/22595#discussion_r3431019895
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -442,6 +448,36 @@ private void
addToExceptionsAndFailedTasksThenClearUpdatingAndPausedTasks(final
}
}
+ private void updateTaskOffsetSumSnapshot() {
+ final Map<StreamsRebalanceData.TaskId, Long> snapshot = new
HashMap<>(updatingTasks.size());
+ for (final Task task : updatingTasks.values()) {
Review Comment:
Hmmm... We are supposed to report in regular intervals, but only if offsets
change. For paused tasks, nothing should change (we might miss the latest
update though) and in general, if we pause a topology, should we continue /
complete a rebalance? Should be fine to not report? Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
