Copilot commented on code in PR #22616:
URL: https://github.com/apache/kafka/pull/22616#discussion_r3435536661
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -725,14 +722,12 @@ public
CompletableFuture<StreamsGroupTopologyDescriptionUpdateResponseData> stre
final int pushedEpoch = request.topologyEpoch();
final TopicPartition tp = topicPartitionFor(groupId);
- // Each terminal branch produces a SetTopologyOutcome carrying the
response and the
- // back-off disposition. Pre-plugin failures (validate / convert /
runtime error)
- // skip the post-plugin stages and are wrapped with BackoffAction.NOOP
by
- // exceptionally so a fenced or unauthorized caller cannot grief the
back-off and
- // suppress legitimate solicitation. Post-plugin failures arm the
back-off; a
- // post-plugin write failing with GroupIdNotFoundException — the group
was deleted
- // between the plugin call and the write — drops the orphaned entry
since no live
- // group remains to throttle.
+ // The back-off is mutated where the disposition is known: pre-plugin
failures (validate /
+ // convert / runtime) never reach the arming code, so a fenced or
unauthorized caller
+ // cannot grief the back-off; a transient plugin failure arms it; and
the post-plugin
+ // bookkeeping write clears it on success, drops the whole entry if
the group was deleted
+ // underneath us, leaves it alone on a coordinator-moved error, or
arms it (see
+ // finishPostPluginWrite).
Review Comment:
This comment references `finishPostPluginWrite`, but that method no longer
exists in this class after the refactor. This is misleading for future readers;
update the reference to the new back-off/write-settlement helper
(`StreamsGroupTopologyDescriptionManager#completeEpochWrite`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
