[ 
https://issues.apache.org/jira/browse/KAFKA-7779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829320#comment-16829320
 ] 

ASF GitHub Bot commented on KAFKA-7779:
---------------------------------------

hachikuji commented on pull request #6081: KAFKA-7779: Avoid unnecessary loop 
iteration in leastLoadedNode
URL: https://github.com/apache/kafka/pull/6081
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Avoid unnecessary loop iteration in leastLoadedNode
> ---------------------------------------------------
>
>                 Key: KAFKA-7779
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7779
>             Project: Kafka
>          Issue Type: Improvement
>          Components: network
>    Affects Versions: 2.1.0
>            Reporter: huxihx
>            Assignee: huxihx
>            Priority: Minor
>
> In NetworkClient.leastLoadedNode, it invokes `isReady` to  check if an 
> established connection exists for the given node. `isReady` checks whether 
> metadata needs to be updated also which wants to make metadata request first 
> priority. However, if the to-be-sent request is metadata request, then we do 
> not have to check this otherwise the loop in `leastLoadedNode` will do a 
> complete iteration until the final node is selected. That's not performance 
> efficient for a large cluster.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to