Shekharrajak commented on code in PR #22357:
URL: https://github.com/apache/kafka/pull/22357#discussion_r3438410430
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTransactionTest.java:
##########
@@ -279,6 +282,53 @@ public void testTransactionalShareAckCommitReject() throws
Exception {
}
}
+ @ClusterTest
+ @Timeout(120)
+ public void testTransactionalShareAckCommitRejectWithDlqEnabled() throws
Exception {
+ String groupId = "txn-share-commit-reject-dlq";
+ String dlqTopic = "dlq." + groupId;
+ createDlqTopic(dlqTopic);
+ alterShareAutoOffsetReset(groupId, "earliest");
+ alterShareGroupConfig(groupId,
GroupConfig.ERRORS_DEADLETTERQUEUE_TOPIC_NAME_CONFIG, dlqTopic);
+
+ try (Producer<byte[], byte[]> producer = createProducer();
+ Producer<byte[], byte[]> transactionalProducer =
createTransactionalProducer("txn-share-commit-reject-dlq-producer");
+ ShareConsumer<byte[], byte[]> shareConsumer = createShareConsumer(
+ groupId,
+ Map.of(ConsumerConfig.SHARE_ACKNOWLEDGEMENT_MODE_CONFIG,
EXPLICIT));
+ Admin admin = createAdminClient()) {
+
+ producer.send(record("dlq-rejected")).get();
+ producer.flush();
+
+ shareConsumer.subscribe(Set.of(tp.topic()));
+ ConsumerRecords<byte[], byte[]> records =
waitedPoll(shareConsumer, 2500L, 1);
+ ConsumerRecord<byte[], byte[]> record = records.iterator().next();
+ assertEquals(0L, record.offset());
+ assertEquals("dlq-rejected", new String(record.value(),
StandardCharsets.UTF_8));
+
+ ShareGroupMetadata groupMetadata =
shareConsumer.shareGroupMetadata();
+ shareConsumer.acknowledge(record, AcknowledgeType.REJECT);
+ ShareAcknowledgements acknowledgements =
shareConsumer.acknowledgementsForTransaction();
+ assertFalse(acknowledgements.isEmpty());
+ TopicIdPartition acknowledgedPartition =
acknowledgements.acknowledgements().keySet().iterator().next();
+ assertEquals(tp, acknowledgedPartition.topicPartition());
+
+ transactionalProducer.initTransactions();
+ transactionalProducer.partitionsFor(tp.topic());
+ transactionalProducer.beginTransaction();
+
transactionalProducer.sendShareAcknowledgementsToTransaction(acknowledgements,
groupMetadata);
+ verifyLatestShareStateDeliveryState(groupId,
acknowledgedPartition, 0L, RecordState.TX_PENDING);
+ transactionalProducer.commitTransaction();
+
+ assertEquals(0,
shareConsumer.poll(Duration.ofMillis(1000)).count());
+ verifySharePartitionLag(admin, groupId, tp, 0L);
+ waitForDlqRecords(dlqTopic, 1);
+ verifyLatestShareStateDeliveryState(groupId,
acknowledgedPartition, 0L, RecordState.ARCHIVED);
Review Comment:
proves commit+reject with DLQ enabled writes one DLQ record and ends in
ARCHIVED.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
