[
https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18090020#comment-18090020
]
Preethi KCS edited comment on KAFKA-14922 at 6/18/26 9:11 PM:
--------------------------------------------------------------
Hi Matthias, Thanks for the detailed clarification about {{--force}} meaning
'force the reset' with member deletion being an impl detail.
I was initially confused, as one reviewer concern
([https://github.com/apache/kafka/pull/21826/changes#r3383831217] ) was that
using the same {{--force}} flag to cover two different validation bypasses
(active group member removal vs. application-id existence check). From a
reviewer perspective, this can look like a semantic coupling of unrelated
behaviors under one flag.
Before working on further changes, I just wanted to align all of us, if we are
defining {{--force}} as a unified “skip all blocking validations for reset”
semantic going forward. If so, I can align the PR/docs accordingly and clarify
the same in the KIP. I will try to cover all possible pros and cons of both
approach. I have requested for credentials on confluence to create KIP. Once i
get access, I can start a KIP.
Thanks [~mjsax].
was (Author: JIRAUSER312624):
Hi Matthias, Thanks for the detailed clarification, I was confused as one
concern raised in review (
[https://github.com/apache/kafka/pull/21826/changes#r3383831217] ) is that
using the same {{--force}} flag to cover two different validation bypasses
(active group member removal vs. application-id existence check). From a
reviewer perspective, this can look like a semantic coupling of unrelated
behaviors under one flag.
Before working on further changes, I just wanted to align all of us, if we are
defining {{--force}} as a unified “skip all blocking validations for reset”
semantic going forward. If so, I can align the PR/docs accordingly and clarify
the same in the KIP. I will try to cover all possible pros and cons of both
approach. I have requested for credentials on confluence to create KIP. Once i
get access, I can start a KIP.
Thanks [~mjsax].
> kafka-streams-application-reset deletes topics not belonging to specified
> application-id
> ----------------------------------------------------------------------------------------
>
> Key: KAFKA-14922
> URL: https://issues.apache.org/jira/browse/KAFKA-14922
> Project: Kafka
> Issue Type: Bug
> Components: streams, tools
> Affects Versions: 3.4.0
> Reporter: Jørgen
> Assignee: Preethi KCS
> Priority: Major
> Labels: beginner, needs-kip, newbie
>
> Slack-thread:
> [https://confluentcommunity.slack.com/archives/C48AHTCUQ/p1681908267206849]
> When running the command _kafka-streams-application-reset --bootstrap-servers
> $BOOTSTRAP --application-id foo_ all internal topics that _starts with_ foo
> is deleted. This happens even if there's no application-id named foo.
> Example:
> {code:java}
> Application IDs:
> foo-v1
> foo-v2
> Internal topics:
> foo-v1-repartition-topic-repartition
> foo-v2-repartition-topic-repartition
> Application reset:
> kafka-streams-application-reset --bootstrap-servers $BOOTSTRAP
> --application-id foo
> > No input or intermediate topics specified. Skipping seek.
> Deleting inferred internal topics [foo-v2-repartition-topic-repartition,
> foo-v1-repartition-topic-repartition]
> Done.{code}
> Expected behaviour is that the command fails as there are no application-id's
> with the name foo instead of deleting all foo* topics.
> This is critical on typos or if application-ids starts with the same name as
> others (for example if we had foo-v21 and wanted to reset foo-v2)
> The bug should be located here:
> [https://github.com/apache/kafka/blob/c14f56b48461f01743146d58987bc8661ba0d459/tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java#L693]
> Should check that the topics matches the application-id exactly instead of
> checking that it starts with the application-id.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
