lucasbru commented on PR #22612: URL: https://github.com/apache/kafka/pull/22612#issuecomment-4752745157
Separately (since `TopologyTestDriver.java` isn't changed in this PR): `readRecord()` at line 840 constructs output `TestRecord`s via `new TestRecord<>(key, value, record.headers(), record.timestamp())` — the 4-arg Long constructor — so `record.partition()` is dropped and output records always get `partition == -1`. The field Javadoc says output records always carry the real resolved partition, but that won't be true until this call site is updated. Is that deferred to a follow-up PR, or should it be fixed here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
