nicktelford commented on code in PR #22625:
URL: https://github.com/apache/kafka/pull/22625#discussion_r3451230445
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -336,7 +343,8 @@ void openRocksDB(final DBOptions dbOptions,
new ColumnFamilyDescriptor(OFFSETS_COLUMN_FAMILY_NAME,
offsetsCFOptions())
);
- cfAccessor = new SingleColumnFamilyAccessor(columnFamilies.get(1),
columnFamilies.get(0));
+ dataColumnFamily = columnFamilies.get(0);
Review Comment:
By convention, the *last* CF is offsets (see: line 342). The reason for this
is that the default CF has historically been used for data, and that has always
been the first CF in the list, so we just added a new CF to the end of the list
for offsets.
FWIW, this LoC has been replaced now, due to an unrelated bug that I fixed
in 5a1a939.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
