nileshkumar3 commented on code in PR #22035:
URL: https://github.com/apache/kafka/pull/22035#discussion_r3456313969
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -166,6 +167,7 @@ public void run() {
}
}
} catch (Throwable t) {
+ maybeSetFatalError(t);
Review Comment:
Agreed. With init failures handled in the inner catch (and returned early)
and runOnce() errors swallowed in the loop, the outer catch is effectively
unreachable for setting a meaningful fatal error. I've removed fatalError and
maybeSetFatalError() — the outer catch now only logs unexpected failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
