Preethi-Sundaravelu commented on code in PR #21826:
URL: https://github.com/apache/kafka/pull/21826#discussion_r3456634920
##########
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##########
@@ -520,7 +546,11 @@ private Map<TopicPartition, Long> checkOffsetRange(final
Map<TopicPartition, Lon
return validatedTopicPartitionsOffsets;
}
- private int maybeDeleteInternalTopics(final Admin adminClient, final
StreamsResetterOptions options) {
+ private int maybeDeleteInternalTopics(final Admin adminClient, final
StreamsResetterOptions options) throws ExecutionException,
InterruptedException, TimeoutException {
+ if (!options.hasForce()) {
Review Comment:
I'm waiting for the Apache team to grant me permission to create KIP.
Meanwhile, could you please check out this comment in
[KAFKA-14922](https://issues.apache.org/jira/browse/KAFKA-14922), as Matthias
and I discussed about defining --force as a unified “skip all blocking
validations for reset” semantic.
Moving forward, once the team is on same page, I will update the PR
addressing the below comments, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
