nicktelford commented on PR #22643: URL: https://github.com/apache/kafka/pull/22643#issuecomment-4777060388
@nileshkumar3 Hi Nilesh, thanks for this. This is actually the exact strategy I was planning to use to provide snapshot isolation for Interactive Queries over RocksDBStores. _However_, I have since learned that constructing an Iterator in RocksDB _implicitly takes a consistent snapshot of the ColumnFamily being iterated_. Consequently, explicit `Snapshot`s are only necessary under certain when you need to create multiple Iterators over different CFs that have the same, consistent view of the db, as RocksDBVersionedStateStore does. In conclusion, I think this is unnecessary, and we can instead just merge @mjsax #22646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
