lucasbru commented on code in PR #22559:
URL: https://github.com/apache/kafka/pull/22559#discussion_r3469655409
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManagerTest.java:
##########
@@ -1542,6 +1554,51 @@ public void testOnHeartbeatSuccessWhenInLeaving() {
verify(memberStateListener,
never()).onMemberEpochUpdated(Optional.of(MEMBER_EPOCH + 1),
membershipManager.memberId());
}
+ @ParameterizedTest
+ @MethodSource("staticMemberLeaveOnCloseOperations")
+ public void testStaticMemberUsesExpectedLeaveEpochOnClose(
Review Comment:
It seems to me you added this parametrized test and did not remove plain
tests. Can you fix this in the following PR @chickenchickenlove ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
