smjn commented on PR #22601: URL: https://github.com/apache/kafka/pull/22601#issuecomment-4793882826
> @smjn I was expecting a single readLog method in LogReader which abstracts whether to fetch from local log or remote, it just provides a CompletableFuture. Do you think that can be achieved instead of two methods in LogReader? @apoorvmittal10 The current `read` method needs to stay until `DelayedShareFetch` is updated. Post that we could remove that - I would recommend 2 methods `read(options)` which always fetches remote and `read(options, boolean fetchRemote)` for flexibility. The `readRemote` method in the impl class is private. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
