chickenchickenlove commented on code in PR #22561:
URL: https://github.com/apache/kafka/pull/22561#discussion_r3474603672
##########
tests/kafkatest/tests/streams/streams_static_membership_test.py:
##########
@@ -53,12 +63,7 @@ def __init__(self, test_context):
def
test_rolling_bounces_will_not_trigger_rebalance_under_static_membership(self,
metadata_quorum):
Review Comment:
This test still uses the default classic group protocol through
`create_processors(self.num_threads)`. I only enable the streams group protocol
in the tests that explicitly cover streams-group behavior.
```python
def
test_rolling_bounces_will_not_trigger_rebalance_under_static_membership(self,
metadata_quorum):
...
processors = self.create_processors(self.num_threads)
...
def create_processors(self, num_threads, group_protocol="classic",
persistent_process_id_store_enabled=False):
return [ ... ]
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
