chia7712 commented on code in PR #22521:
URL: https://github.com/apache/kafka/pull/22521#discussion_r3474859811
##########
build.gradle:
##########
@@ -3081,6 +3109,14 @@ project(':streams:integration-tests') {
srcDirs = []
}
}
+ testFixtures {
+ java {
+ srcDirs = []
+ }
+ scala {
Review Comment:
> StreamToTableJoinScalaIntegrationTestImplicitSerdes which tests Scala
implicits.
nice point. I'd like to open another PR to handle it first.
1. rewrite `StreamToTableJoinScalaIntegrationTestImplicitSerdes` using
`TopologyTestDriver` to avoid using a true kafka cluster
2. move it to the streams-scala module
3. remove `StreamToTableJoinScalaIntegrationTestBase`,
`StreamToTableJoinTestData`, and `WordCountTest`
4. remove the scala dependency from streams:integration-tests module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
