lucasbru commented on code in PR #22649:
URL: https://github.com/apache/kafka/pull/22649#discussion_r3485258239
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -808,7 +819,8 @@ private void recordRatio(final long now,
private final Lock tasksAndActionsLock = new ReentrantLock();
private final Condition tasksAndActionsCondition =
tasksAndActionsLock.newCondition();
private final Queue<StreamTask> restoredActiveTasks = new LinkedList<>();
- private final Lock restoredActiveTasksLock = new ReentrantLock();
+ // visible for testing
+ final Lock restoredActiveTasksLock = new ReentrantLock();
Review Comment:
We are using the same lock in other places without making it visible for
testing.
How are we testing the other uses of the lock. Can we make it consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
