brandboat commented on code in PR #22531:
URL: https://github.com/apache/kafka/pull/22531#discussion_r3488278399
##########
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java:
##########
@@ -1864,6 +1864,22 @@ default ListClientMetricsResourcesResult
listClientMetricsResources() {
*/
Uuid clientInstanceId(Duration timeout);
+ /**
+ * Add a new voter node to the KRaft metadata quorum.
+ *
+ * <p>
+ * This is a convenience method that derives the voter's directory ID and
endpoints
+ * from the active controller's in-memory state. It is not idempotent.
+ * For scenarios such as node disk failure where multiple observers may
share the same
+ * node ID with different directory UUIDs, use
+ * {@link #addRaftVoter(int, Uuid, Set, AddRaftVoterOptions)} instead.
+ *
+ * @param voterId The node ID of the voter to add.
+ */
+ default AddRaftVoterResult addRaftVoter(int voterId) {
Review Comment:
Good catch! Yeah you're right, I totally missed the `AddRaftVoterOptions`
usage, will modify KIP later and send email, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
