squah-confluent commented on code in PR #22658:
URL: https://github.com/apache/kafka/pull/22658#discussion_r3491899499
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -4309,7 +4309,7 @@ private UpdateTargetAssignmentResult<Map<String,
TasksTuple>> maybeUpdateStreams
if (group.assignmentEpoch() >= groupEpoch) {
// The assignment is up to date.
- return new UpdateTargetAssignmentResult<>(group.assignmentEpoch(),
group.targetAssignment());
+ return new UpdateTargetAssignmentResult<>(group.assignmentEpoch(),
targetAssignmentWithStaticRelabelling(group, updatedMember));
Review Comment:
Now that #22692 is merged, I think it's cleaner to lift
`updatedMembersAndTargetAssignment` higher up in this method and use its target
assignment instead of trying to re-create the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
