chia7712 commented on code in PR #22699:
URL: https://github.com/apache/kafka/pull/22699#discussion_r3498683824
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -725,7 +725,7 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
CompressionType compressionType =
ClientTelemetryUtils.preferredCompressionType(localSubscription.acceptedCompressionTypes(),
unsupportedCompressionTypes);
ByteBuffer compressedPayload;
try {
- compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
+ compressedPayload =
ClientTelemetryUtils.compress(payload.toByteArray(), compressionType);
Review Comment:
Currently, `ClientTelemetryUtils.compress` is exposed for mocking and
throwing an expected exception. We can mock `Compression#of` instead, and it
works perfectly since `ClientTelemetryUtils.compress` uses it internally to
create a Compression object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
