mjsax commented on code in PR #22673:
URL: https://github.com/apache/kafka/pull/22673#discussion_r3502243158
##########
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java:
##########
@@ -837,7 +846,9 @@ <K, V> TestRecord<K, V> readRecord(final String topic,
}
final K key = keyDeserializer.deserialize(record.topic(),
record.headers(), record.key());
final V value = valueDeserializer.deserialize(record.topic(),
record.headers(), record.value());
- return new TestRecord<>(key, value, record.headers(),
record.timestamp());
+ final int outputPartition = -1;
Review Comment:
Ah, yes, I did mean `0` of course...
But your point about breaking existing tests is crucial. In the end, it does
not only affect our tests in `kafka.git` but all existing user tests, too, and
we should not break them. So I think we better keep `-1` and update the KIP
accordingly, and explain why `-1` is necessary for single-partition mode to
preserve backward compatiblity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
