[
https://issues.apache.org/jira/browse/KAFKA-20754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Quah updated KAFKA-20754:
------------------------------
Description:
Currently we allow static members to rejoin with the same member id and
different instance id. This is an interaction that the Java client will never
do and is rarely considered when reviewing patches. It leads to odd corner case
bugs like KAFKA-20747.
It would be simpler to forbid instance id changes entirely when keeping member
ids the same.
* Forbid addition of an instance id to a non-static member.
* Forbid a swap of instance id.
* Forbid the removal of an instance id from a static member. Right now this
retains the existing instance id
Then consider cleaning up [https://github.com/apache/kafka/pull/22708],
[https://github.com/apache/kafka/pull/22713] and TargetAssignmentRecordsBuilder
tests.
was:
Currently we allow static members to rejoin with the same member id and
different instance id. This is an interaction that the Java client will never
do and is rarely considered when reviewing patches. It leads to odd corner case
bugs like KAFKA-20747.
It would be simpler to forbid instance id changes entirely when keeping member
ids the same.
* Forbid addition of an instance id to a non-static member.
* Forbid a swap of instance id.
* Forbid the removal of an instance id from a static member. Right now this
retains the existing instance id.
> Disallow static member instance id changes
> ------------------------------------------
>
> Key: KAFKA-20754
> URL: https://issues.apache.org/jira/browse/KAFKA-20754
> Project: Kafka
> Issue Type: Improvement
> Components: group-coordinator
> Reporter: Sean Quah
> Assignee: Sean Quah
> Priority: Minor
>
> Currently we allow static members to rejoin with the same member id and
> different instance id. This is an interaction that the Java client will never
> do and is rarely considered when reviewing patches. It leads to odd corner
> case bugs like KAFKA-20747.
> It would be simpler to forbid instance id changes entirely when keeping
> member ids the same.
> * Forbid addition of an instance id to a non-static member.
> * Forbid a swap of instance id.
> * Forbid the removal of an instance id from a static member. Right now this
> retains the existing instance id
> Then consider cleaning up [https://github.com/apache/kafka/pull/22708],
> [https://github.com/apache/kafka/pull/22713] and
> TargetAssignmentRecordsBuilder tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
