coltmcnealy-lh commented on code in PR #21438:
URL: https://github.com/apache/kafka/pull/21438#discussion_r3509306542
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -701,7 +702,7 @@ private StateUpdater.RemovedTaskResult waitForFuture(final
TaskId taskId,
final
CompletableFuture<StateUpdater.RemovedTaskResult> future) {
final StateUpdater.RemovedTaskResult removedTaskResult;
try {
- removedTaskResult = future.get();
+ removedTaskResult = future.get(5, TimeUnit.MINUTES);
Review Comment:
5 minutes seems to be a very long time given that this function is called in
the run loop on the `StreamThread`. I would say anything longer than 5 seconds
poses a risk, given the default transaction timeout of 10 seconds and the
consumer poll timeout being maxed out at 5 minutes.
In practice, if we get to this error, something else has gone wrong (for
example, see this ticket: https://issues.apache.org/jira/browse/KAFKA-19853)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
