adixitconfluent commented on code in PR #22707:
URL: https://github.com/apache/kafka/pull/22707#discussion_r3511377832
##########
core/src/main/java/kafka/server/share/ReplicaManagerLogReader.java:
##########
@@ -147,6 +149,7 @@ public CompletableFuture<LinkedHashMap<TopicIdPartition,
LogReadResult>> readAsy
return withInfoAndError(logReadResult, localFetchDataInfo,
Errors.forException(cause));
}
if (remoteFetchDataInfo == null) {
+ // We want to return successful local read results so no
skipping.
return withInfoAndError(logReadResult, localFetchDataInfo,
Errors.UNKNOWN_SERVER_ERROR);
Review Comment:
Question - When is this scenario possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
