chia7712 commented on code in PR #20598:
URL: https://github.com/apache/kafka/pull/20598#discussion_r3521059833


##########
tools/src/main/java/org/apache/kafka/tools/ClusterTool.java:
##########
@@ -208,4 +222,23 @@ static void listEndpoints(PrintStream stream, Admin 
adminClient, boolean listCon
             }
         }
     }
+
+    static void apiVersionsCommand(PrintStream stream, Admin adminClient) 
throws Exception {
+        Collection<Node> nodes = adminClient.describeCluster().nodes().get();
+        Map<Node, InternalDescribeFeaturesResult> nodeApiVersions = new 
TreeMap<>(Comparator.comparingInt(Node::id));
+        nodes.forEach(node -> {
+            InternalDescribeFeaturesResult result = 
(InternalDescribeFeaturesResult) adminClient.describeFeatures(
+                    new DescribeFeaturesOptions().nodeId(node.id()));
+            nodeApiVersions.put(node, result);
+        });
+
+        nodeApiVersions.forEach((broker, future) -> {
+            try {
+                NodeApiVersions apiVersions = future.nodeApiVersions().get();
+                stream.print(broker + " -> " + apiVersions.toString(true) + 
"\n");

Review Comment:
   ```
   chia7712@2001-b400-e661-33b9-bd58-8071-309e-9ab2:~/project/kafka$ 
bin/kafka-cluster.sh api-versions --bootstrap-server localhost:19091
   172.20.10.3:19091 (id: 2 rack: null isFenced: false) -> (
        Produce(0): 0 to 13 [usable: 13],
        Fetch(1): 4 to 18 [usable: 18],
        ListOffsets(2): 1 to 11 [usable: 11],
        Metadata(3): 0 to 13 [usable: 13],
        OffsetCommit(8): 2 to 10 [usable: 10],
        OffsetFetch(9): 1 to 10 [usable: 10],
        FindCoordinator(10): 0 to 6 [usable: 6],
        JoinGroup(11): 0 to 9 [usable: 9],
        Heartbeat(12): 0 to 4 [usable: 4],
        LeaveGroup(13): 0 to 5 [usable: 5],
        SyncGroup(14): 0 to 5 [usable: 5],
        DescribeGroups(15): 0 to 6 [usable: 6],
        ListGroups(16): 0 to 5 [usable: 5],
        SaslHandshake(17): 0 to 1 [usable: 1],
        ApiVersions(18): 0 to 4 [usable: 4],
        CreateTopics(19): 2 to 7 [usable: 7],
        DeleteTopics(20): 1 to 6 [usable: 6],
        DeleteRecords(21): 0 to 2 [usable: 2],
        InitProducerId(22): 0 to 5 [usable: 5],
        OffsetForLeaderEpoch(23): 2 to 4 [usable: 4],
        AddPartitionsToTxn(24): 0 to 5 [usable: 5],
        AddOffsetsToTxn(25): 0 to 4 [usable: 4],
        EndTxn(26): 0 to 5 [usable: 5],
        WriteTxnMarkers(27): 1 to 2 [usable: 2],
        TxnOffsetCommit(28): 0 to 6 [usable: 6],
        DescribeAcls(29): 1 to 3 [usable: 3],
        CreateAcls(30): 1 to 3 [usable: 3],
        DeleteAcls(31): 1 to 3 [usable: 3],
        DescribeConfigs(32): 1 to 4 [usable: 4],
        AlterConfigs(33): 0 to 2 [usable: 2],
        AlterReplicaLogDirs(34): 1 to 2 [usable: 2],
        DescribeLogDirs(35): 1 to 5 [usable: 5],
        SaslAuthenticate(36): 0 to 2 [usable: 2],
        CreatePartitions(37): 0 to 3 [usable: 3],
        CreateDelegationToken(38): 1 to 3 [usable: 3],
        RenewDelegationToken(39): 1 to 2 [usable: 2],
        ExpireDelegationToken(40): 1 to 2 [usable: 2],
        DescribeDelegationToken(41): 1 to 3 [usable: 3],
        DeleteGroups(42): 0 to 3 [usable: 3],
        ElectLeaders(43): 0 to 2 [usable: 2],
        IncrementalAlterConfigs(44): 0 to 1 [usable: 1],
        AlterPartitionReassignments(45): 0 to 1 [usable: 1],
        ListPartitionReassignments(46): 0 [usable: 0],
        OffsetDelete(47): 0 [usable: 0],
        DescribeClientQuotas(48): 0 to 1 [usable: 1],
        AlterClientQuotas(49): 0 to 1 [usable: 1],
        DescribeUserScramCredentials(50): 0 [usable: 0],
        AlterUserScramCredentials(51): 0 [usable: 0],
        DescribeQuorum(55): 0 to 2 [usable: 2],
        UpdateFeatures(57): 0 to 2 [usable: 2],
        DescribeCluster(60): 0 to 2 [usable: 2],
        DescribeProducers(61): 0 [usable: 0],
        UnregisterBroker(64): 0 [usable: 0],
        DescribeTransactions(65): 0 [usable: 0],
        ListTransactions(66): 0 to 2 [usable: 2],
        ConsumerGroupHeartbeat(68): 0 to 1 [usable: 1],
        ConsumerGroupDescribe(69): 0 to 1 [usable: 1],
        GetTelemetrySubscriptions(71): UNSUPPORTED,
        PushTelemetry(72): UNSUPPORTED,
        ListConfigResources(74): 0 to 1 [usable: 1],
        DescribeTopicPartitions(75): 0 [usable: 0],
        ShareGroupHeartbeat(76): 1 [usable: 1],
        ShareGroupDescribe(77): 1 [usable: 1],
        ShareFetch(78): 1 to 2 [usable: 2],
        ShareAcknowledge(79): 1 to 2 [usable: 2],
        AddRaftVoter(80): 0 to 1 [usable: 1],
        RemoveRaftVoter(81): 0 [usable: 0],
        InitializeShareGroupState(83): 0 [usable: 0],
        ReadShareGroupState(84): 0 [usable: 0],
        WriteShareGroupState(85): 0 to 1 [usable: 1],
        DeleteShareGroupState(86): 0 [usable: 0],
        ReadShareGroupStateSummary(87): 0 to 1 [usable: 1],
        StreamsGroupHeartbeat(88): 0 to 1 [usable: 1],
        StreamsGroupDescribe(89): 0 to 1 [usable: 1],
        DescribeShareGroupOffsets(90): 0 to 1 [usable: 1],
        AlterShareGroupOffsets(91): 0 [usable: 0],
        DeleteShareGroupOffsets(92): 0 [usable: 0],
        StreamsGroupTopologyDescriptionUpdate(93): 0 [usable: 0]
   )
   ```
   
   Should we format the output?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to